Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a debugging utility for Rust generate! #828

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add a debugging utility for Rust generate! #828

merged 1 commit into from
Feb 2, 2024

Conversation

alexcrichton
Copy link
Member

Lift the approach I added in bytecodealliance/wasmtime#7794

@jsturtevant
Copy link
Collaborator

Super useful! I guess this could be used instead of cargo expand? Maybe can update the readme where cargo expand is mentioned to called this option out?

Mossaka
Mossaka approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alexcrichton
Copy link
Member Author

Good point @jsturtevant! Looks like the README could use an update on a few other dimensions as well so I'll follow-up with that.

@alexcrichton alexcrichton merged commit 9214a62 into bytecodealliance:main Feb 2, 2024
9 checks passed
@alexcrichton alexcrichton deleted the debug branch February 2, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcrichton @jsturtevant @Mossaka